Skip to content

[Messaging] Fix deprecated UNNotificationPresentationOptions (#1784) #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2025
Merged

[Messaging] Fix deprecated UNNotificationPresentationOptions (#1784) #1785

merged 5 commits into from
Oct 20, 2025

Conversation

@devPaidion
Copy link
Contributor

@devPaidion devPaidion commented Oct 16, 2025 •
edited
Loading

Issue Description

UNNotificationPresentationOptionAlert has been deprecated.

Possible Solutions

Separately set the UNNotificationPresentationOptions by available iOS version.
Replace .alert into .list and .banner.

Reference

Apple Developer Documentation
Screenshot 2025-10-16 at 9 07 01 PM

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 16, 2025

Summary of Changes

Hello @devPaidion, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a deprecation warning related to UNNotificationPresentationOptionAlert in the messaging example application. It introduces version-specific handling for notification presentation options, ensuring that modern iOS versions utilize the recommended list and banner styles while maintaining compatibility with older iOS versions. This change ensures the example app adheres to current Apple API guidelines and provides correct notification behavior across different iOS environments.

Highlights

  • Deprecation Fix: Addressed the deprecation of UNNotificationPresentationOptionAlert in iOS by updating the notification presentation options.
  • Conditional Logic for iOS Versions: Implemented conditional logic to set UNNotificationPresentationOptions based on the available iOS version, ensuring compatibility.
  • Updated Notification Presentation: For iOS 14.0 and above, notifications will now be presented as list and banner in addition to sound, replacing the deprecated alert option.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the deprecated UNNotificationPresentationOptionAlert for the Swift example by using an #available check for iOS 14. However, the implementation has a small typo that will cause a compilation error. I've provided a review comment with a suggested fix that also improves code conciseness and style consistency. It would also be beneficial to apply a similar fix to the Objective-C example in messaging/MessagingExample/AppDelegate.m, which still uses the deprecated option.

ncooke3
ncooke3 approved these changes Oct 16, 2025
View reviewed changes
@devPaidion devPaidion requested a review from ncooke3 October 19, 2025 11:05
@ncooke3
Copy link
Member

ncooke3 commented Oct 20, 2025

Thanks, @devPaidion!

@ncooke3 ncooke3 merged commit 26d2fe2 into firebase:main Oct 20, 2025
2 of 3 checks passed
@ncooke3 ncooke3 mentioned this pull request Oct 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devPaidion @ncooke3